Fileuplad via Stored XSS

https://github.com/advisories/GHSA-x8gm-j36p-fppf

CVE-2024-47528 - GitHub Advisory Database

 

Description

Summary

Stored Cross-Site Scripting (XSS) can archive via Uploading a new Background for a Custom Map.

Details

Users with "admin" role can set background for a custom map, this allow the upload of SVG file that can contain XSS payload which will trigger onload. This led to Stored Cross-Site Scripting (XSS).

PoC

1. Login using an Admin role account.
2. Go over to "$URL/maps/custom", the Manage Custom Maps.
   

   

3. Create a new map then choose to edit it.
4. Choose the "Set Background" option.
   

   

5. Choose to upload a SVG file that have this content.

<svg xmlns="http://www.w3.org/2000/svg" onload="alert(document.domain)">
  <circle cx="50" cy="50" r="40" />
</svg>

1. Once uploaded, there should be a link to the SVG return in the POST request to the API "$URL/maps/custom/1/background".
   

   

2. Go over to that link on browser, should see a pop-up.
   

   

Impact

Attacker can use this to perform malicious java script code for malicious intent.
This would impact other Admin role users and the Global Read role users. Normal users does not have permission to read the file, so they are not affected.

References

• GHSA-x8gm-j36p-fppf
• https://nvd.nist.gov/vuln/detail/CVE-2024-47528
• librenms/librenms@d959bf1